Ayal Baron has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
......................................................................
Patch Set 5:
(3 comments)
....................................................
File vdsm/storage/lvm.py
Line 657: activelvs = [(lv.vg_name, lv.opened, lv.name)
Line 658: for lv in _lvminfo.getAllLvs() if lv.active]
Line 659: activelvs.sort()
Line 660: for (vg, opened), group in groupby(activelvs, lambda triple:
triple[:2]):
Line 661: lvs = [triple[2] for triple in group]
I wonder if it wouldn't be more legible to do this explicitly and not with
groupby etc
Line 662: if opened:
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
Line 659: activelvs.sort()
Line 660: for (vg, opened), group in groupby(activelvs, lambda triple:
triple[:2]):
Line 661: lvs = [triple[2] for triple in group]
Line 662: if opened:
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
why is this warning vs. info?
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
Line 666: try:
Line 667: _setLVAvailability(vg, lvs, "n")
Line 661: lvs = [triple[2] for triple in group]
Line 662: if opened:
Line 663: log.warning("Skipping open lvs: vg=%s lvs=%s", vg, lvs)
Line 664: else:
Line 665: log.info("Deactivating lvs: vg=%s lvs=%s", vg, lvs)
why is this *not* warning?
Line 666: try:
Line 667: _setLVAvailability(vg, lvs, "n")
Line 668: except se.CannotDeactivateLogicalVolume:
Line 669: log.error("Error deactivating lvs: vg=%s lvs=%s", vg,
lvs)
--
To view, visit http://gerrit.ovirt.org/21291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
