Federico Simoncelli has posted comments on this change. Change subject: lvm: deactivate lvs during bootstrap ......................................................................
Patch Set 7: Code-Review+2 (1 comment) When/if properly tested this is good enough for me. .................................................... File vdsm/storage/lvm.py Line 649: Line 650: _lvminfo = LVMCache() Line 651: Line 652: Line 653: def bootstrap(refreshlvs=()): Sounds like a valid fallback plan. Adding a locking mechanism for bootstrap and activation/deactivation (as you know) is probably the more correct way to go (but I suppose it will take time to get it right and to test it wrt timeouts, etc.). Line 654: """ Line 655: Bootstrap lvm module Line 656: Line 657: This function builds the lvm cache and ensure that all unused lvs are -- To view, visit http://gerrit.ovirt.org/21291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches