Nir Soffer has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. ......................................................................
Patch Set 3: (2 comments) Looks good, need to check if special lvs are handled in the modified code path. .................................................... File vdsm/storage/blockSD.py Line 1067: Line 1068: If the image is based on a template image it will be activated. Line 1069: """ Line 1070: toRefresh = [vol for vol in volUUIDs if vol not in SPECIAL_LVS and Line 1071: lvm.isLVActive(self.sdUUID, vol)] Special lvs belong to an image? Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs) Line 1073: Line 1074: if toRefresh: Line 1075: log.warning("The following volumes are already active and will be" Line 1068: If the image is based on a template image it will be activated. Line 1069: """ Line 1070: toRefresh = [vol for vol in volUUIDs if vol not in SPECIAL_LVS and Line 1071: lvm.isLVActive(self.sdUUID, vol)] Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs) I agree. Line 1073: Line 1074: if toRefresh: Line 1075: log.warning("The following volumes are already active and will be" Line 1076: " refreshed before use : %s", toRefresh) -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches