Dan Kenigsberg has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. ......................................................................
Patch Set 7: (2 comments) .................................................... Commit Message Line 8: Line 9: At present we trust that active LVs represent the current state of a Line 10: given LV. This may not be the case if the LV has been modified Line 11: (extended, recreated etc) by another host while the LV is active on Line 12: the current host. Could you detail how we can get to such a condition? http://gerrit.ovirt.org/#/c/21291/ fixes the two cases that I am aware of (auto activate on boot and vdsm crash after activation). Line 13: Line 14: This change forces active LVs that are part of a guest image to be Line 15: refreshed before use. Line 16: .................................................... File vdsm/storage/blockSD.py Line 1073: Line 1074: if toRefresh: Line 1075: log.warning("The following volumes are already active and will be" Line 1076: " refreshed before use : %s", toRefresh) Line 1077: lvm.refreshLVs(self.sdUUID, toRefresh) until http://gerrit.ovirt.org/#/c/8382/ is in, this could be a problem for shared volumes, which are written to by another VM. Line 1078: Line 1079: vgDir = os.path.join("/dev", self.sdUUID) Line 1080: return self.createImageLinks(vgDir, imgUUID, volUUIDs) Line 1081: -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
