Nir Soffer has posted comments on this change.

Change subject: lvm: deactivate lvs during bootstrap
......................................................................


Patch Set 8: Verified+1

Fixes:
- Typo in getAllVgs() - turns out there is both getAllVgs() and getAllVGs(), I 
used the wrong one
- getAllVgs returns vg object, not vg name. Use vg.name when we need the name
- Check if deactivate and refresh list are empty, otherwise the code would try 
to deactivate or refresh all lvs when the lists are empty

Verified:

- Deactivates unused lvs
- Skip open lvs used by running vms
- Refresh special lvs
- Sanity: create new domain, create 4 vms, run 2 vm and install system from iso
- Restart vdsm while vms are running

-- 
To view, visit http://gerrit.ovirt.org/21291
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to