Lee Yarwood has posted comments on this change.

Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................


Patch Set 7: Verified-1

Unfortunately while attempting to verify this change it appears that lvchange 
--refresh is not having the desired effect on volumes that have been modified 
on other hosts. 

For example a common flow where we have seen issues as a result of this in the 
past is with the merging of snapshots. I've attempted a few of these while 
leaving one or more volumes active a HSM. While this change does correctly call 
lvchange --refresh against these before use on the HSM the underlying dm 
structure of the volume is not updated and thus the guest is unable to boot. 
Maybe this is just a lvm2 bug but it really needs more research before we 
verify this change.

-- 
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarw...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to