Antoni Segura Puimedon has posted comments on this change.
Change subject: bootstrap: Return recovery error during lvm bootstrap
......................................................................
Patch Set 3:
(2 comments)
Very insignificant review.
....................................................
File vdsm/storage/hsm.py
Line 324: def __init__(self, readyCallback):
Line 325: """
Line 326: The HSM Constructor
Line 327:
Line 328: :param readyCallback: Called when instance has finished its
deffered
s/deffered/deferred/
Line 329: initialization and is ready to answer
requests.
Line 330: :type readyCallback: function
Line 331: """
Line 332: rm.ResourceManager.getInstance().registerNamespace(
Line 326: The HSM Constructor
Line 327:
Line 328: :param readyCallback: Called when instance has finished its
deffered
Line 329: initialization and is ready to answer
requests.
Line 330: :type readyCallback: function
shouldn't type be "callable"?
Line 331: """
Line 332: rm.ResourceManager.getInstance().registerNamespace(
Line 333: STORAGE, rm.SimpleResourceFactory())
Line 334: self.storage_repository = config.get('irs', 'repository')
--
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
