Nir Soffer has posted comments on this change. Change subject: bootstrap: Return recovery error during lvm bootstrap ......................................................................
Patch Set 3: (1 comment) .................................................... File vdsm/storage/hsm.py Line 376: def storageRefresh(): Line 377: try: Line 378: lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS) Line 379: finally: Line 380: readyCallback() I tried to implement this by checking hsm readiness in wrapIrsMethod. This breaks backward compatibiliity as engine does not handle well a situation where vdsm is not recovering (e.g. respond to getCapabilities), but irs is not ready yet (e.g. return recovery error when asked to connect to storage). This result in host becoming non-operational. I suggest to keep the current design so we have a patch that can be backported, and improving the design later. Line 381: Line 382: sdCache.refreshStorage() Line 383: Line 384: fileUtils.createdir(self.tasksDir) -- To view, visit http://gerrit.ovirt.org/21530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
