Yaniv Bronhaim has posted comments on this change.

Change subject: Peform related services restart after reconfiguring
......................................................................


Patch Set 4:

(1 comment)

....................................................
File vdsm.spec.in
Line 748:         %{_bindir}/vdsm-tool service-stop supervdsmd >/dev/null 2>&1
Line 749:         supervdsmd_start_required='yes'
Line 750:     fi
Line 751: 
Line 752:     %{_bindir}/vdsm-tool libvirt-configure >/dev/null 2>&1
what can we do on error? It will leave libvirtd down and we'll be able to read 
about it in syslog and start it manually
Line 753: 
Line 754:     fi
Line 755:     if [ "${supervdsmd_start_required}" = 'yes' ]; then
Line 756:         %{_bindir}/vdsm-tool service-start supervdsmd >/dev/null 2>&1


-- 
To view, visit http://gerrit.ovirt.org/21356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to