Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: Return recovery error during lvm bootstrap
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
....................................................
File vdsm/clientIF.py
Line 108: self._prepareBindings()
Line 109:
Line 110: @property
Line 111: def ready(self):
Line 112: return (self.irs is None or self.irs.ready) and not
self._recovery
I know that I am to blame about this one, but still:
Let's assume that _recovery changes to False immediately, but HSM()
initialization is slow. ready() may return True as long as self.irs is None,
and then fall back (for a while) to False. Wouldn't this confuse Engine?
Line 113:
Line 114: def contEIOVms(self, sdUUID, isDomainStateValid):
Line 115: # This method is called everytime the onDomainStateChange
Line 116: # event is emitted, this event is emitted even when a domain
goes
....................................................
File vdsm/storage/hsm.py
Line 373: def storageRefresh():
Line 374: try:
Line 375: lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS)
Line 376: finally:
Line 377: self._ready = True
wouldn't we want to signal that only when storageRefresh is done?
The race has existed before lvm.bootstrap() but did not show up. Now we have an
opportunity to close it down.
Also, why do we want to consider ourselves "ready" on an exception? If
lvm.bootstrap() raised before deactivating orphan LVs, we do not want to use
this host's storage.
Line 378: self.log.debug("HSM is ready")
Line 379:
Line 380: sdCache.refreshStorage()
Line 381:
--
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
