Yaniv Bronhaim has posted comments on this change.
Change subject: bootstrap: Return recovery error during lvm bootstrap
......................................................................
Patch Set 4:
(2 comments)
....................................................
File vdsm/clientIF.py
Line 108: self._prepareBindings()
Line 109:
Line 110: @property
Line 111: def ready(self):
Line 112: return (self.irs is None or self.irs.ready) and not
self._recovery
you'll get AttributeError in such case. First time we define self.irs is in
_initIRS. Nir, just move self.irs = None to start
Line 113:
Line 114: def contEIOVms(self, sdUUID, isDomainStateValid):
Line 115: # This method is called everytime the onDomainStateChange
Line 116: # event is emitted, this event is emitted even when a domain
goes
Line 255: self.irs = None
Line 256: if config.getboolean('irs', 'irs_enable'):
Line 257: try:
Line 258: self.irs = Dispatcher(HSM())
Line 259: except:
in separate patch I would change it to utils.panic call
Line 260: self.log.error("Error initializing IRS",
exc_info=True)
Line 261: else:
Line 262:
self.irs.registerDomainStateChangeCallback(self.contEIOVms)
Line 263:
--
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
