Dan Kenigsberg has posted comments on this change.

Change subject: Distribute /var/log/core with vdsm rpm.
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

....................................................
File vdsm.spec.in
Line 626: %if 0%{?fedora} >= 18
Line 627: install -Dm 0644 vdsm/vdsm-libvirt-access.rules \
Line 628:                  
%{buildroot}%{_polkitdir}/10-vdsm-libvirt-access.rules
Line 629: %else
Line 630: install -Dm 0644 vdsm/vdsm-libvirt-access.pkla \
after your change these files are suddenly installed on el6. I do not suppose 
it was intentional, and it is certainly unrelated to the subject of this patch.

Please try to confine your changes to the core dump issue.
Line 631:                  %{buildroot}%{_polkitdir}/10-vdsm-libvirt-access.pkla
Line 632: %endif
Line 633: 
Line 634: %check


-- 
To view, visit http://gerrit.ovirt.org/22211
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7246b4947c0cdb52093c5fe0f60a690d72b1236
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to