Yaniv Bronhaim has posted comments on this change.
Change subject: Distribute /var/log/core with vdsm rpm.
......................................................................
Patch Set 5:
(1 comment)
....................................................
File vdsm.spec.in
Line 596:
Line 597: # Install the configuration sample
Line 598: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
Line 599: %{buildroot}%{_sysconfdir}/vdsm/vdsm.conf
Line 600:
I like this change, and its totally right, but if you do that you must specify
that in the commit message. it can stay in one patch that does 2 things -
making core dump and sample vdsm.conf installed both in rhel and other distros
(btw, maybe you should update also debian folder....) and remove the mkdir part
from pre-start as it does not required anymore
Line 601: %if 0%{?with_systemd}
Line 602: install -Dm 0755 init/systemd/systemd-vdsmd
%{buildroot}/lib/systemd/systemd-vdsmd
Line 603: install -Dm 0644 init/systemd/vdsmd.service
%{buildroot}%{_unitdir}/vdsmd.service
Line 604: install -Dm 0644 init/systemd/supervdsmd.service
%{buildroot}%{_unitdir}/supervdsmd.service
--
To view, visit http://gerrit.ovirt.org/22211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7246b4947c0cdb52093c5fe0f60a690d72b1236
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
