Dan Kenigsberg has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File tests/hooksTests.py
Line 107: os.chmod(NEscript.name, 0o000)
Line 108: info = hooks._getHookInfo(dir)
Line 109: os.unlink(sName)
Line 110: expectedRes = dict([(os.path.basename(sName), {'md5': md5})])
Line 111: self.assertEqual(expectedRes, info)
A proper solution requires the try-finally clause.
Line 112: NEscript.close()
Line 113: os.rmdir(dir)
Line 114:
Line 115: def _deviceCustomPropertiesTestFile(self):
--
To view, visit http://gerrit.ovirt.org/22377
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6581771479de9f72360ea537de32abcdad496b3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
