Dan Kenigsberg has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
....................................................
File tests/hooksTests.py
Line 101: os.unlink(sName)
Line 102: self.assertEqual({'md5': md5}, info)
Line 103:
Line 104: @contextmanager
Line 105: def _namedTemporaryDir(self):
good idea. `git grep mkdtemp` to see why this should be public and sit in
testrunner (you do not need to clean all of them in one patch).
Line 106: tmpDir = tempfile.mkdtemp()
Line 107: try:
Line 108: yield tmpDir
Line 109: finally:
--
To view, visit http://gerrit.ovirt.org/22377
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6581771479de9f72360ea537de32abcdad496b3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
