Bala.FA has posted comments on this change.

Change subject: gluster: additional parsing of host UUID in verb 
glusterVolumesList
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File vdsm/gluster/cli.py
Line 352:         elif transportType == '1':
Line 353:             value['transportType'] = [TransportType.RDMA]
Line 354:         else:
Line 355:             value['transportType'] = [TransportType.TCP, 
TransportType.RDMA]
Line 356:         value['bricks'] = {}
This breaks backward compatibility.  Please fix it
Line 357:         value['options'] = {}
Line 358:         for b in el.findall('bricks/brick'):
Line 359:             value['bricks'][b.text] = b.get('uuid')
Line 360:         for o in el.findall('options/option'):


-- 
To view, visit http://gerrit.ovirt.org/22693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9057f3aea0c0ed8fb4d4ec26eaf66fe80ec581e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to