Darshan N has posted comments on this change.

Change subject: gluster: additional parsing of host UUID in verb 
glusterVolumesList
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/22693/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: gluster: additional parsing of host UUID in verb glusterVolumesList
Line 8: 
Line 9: This patch adds parsing of host UUID for all the bricks in the
Line 10: verb glusterVolumesList.
> Should you update the schema, too?
Done
Line 11: 
Line 12: Change-Id: I9057f3aea0c0ed8fb4d4ec26eaf66fe80ec581e2
Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1038988


http://gerrit.ovirt.org/#/c/22693/2/tests/gluster_cli_tests.py
File tests/gluster_cli_tests.py:

Line 115:             {'music': {'brickCount': '2',
Line 116:                        'bricks': ['192.168.122.2:/tmp/music-b1',
Line 117:                                   '192.168.122.2:/tmp/music-b2'],
Line 118:                        'distCount': '2',
Line 119:                        'hostUuid': {'192.168.122.2:/tmp/music-b1': 
'04eb591b-2fd3-489e-a22c-5d342a3c713d',
> Please keep shorter lines.
Done
Line 120:                                     '192.168.122.2:/tmp/music-b2': 
'04eb591b-2fd3-489e-a22c-5d342a3c713d'},
Line 121:                        'options': {'auth.allow': '*'},
Line 122:                        'replicaCount': '2',
Line 123:                        'stripeCount': '1',


-- 
To view, visit http://gerrit.ovirt.org/22693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9057f3aea0c0ed8fb4d4ec26eaf66fe80ec581e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Darshan N <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to