Dan Kenigsberg has posted comments on this change. Change subject: vdsm: fix RTC offset ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/14750/3/vdsm/vm.py File vdsm/vm.py: Line 1813: self._incomingMigrationFinished = threading.Event() Line 1814: self.id = self.conf['vmId'] Line 1815: self._volPrepareLock = threading.Lock() Line 1816: self._initTimePauseCode = None Line 1817: self._initTimeRTC = long(self.conf['timeOffset']) elsewhere, the code has self.conf.get('timeOffset', 0) so Federico's worry may be justified - could it be that some times, timeOffset is not sent by some ancient Engine? Line 1818: self.guestAgent = None Line 1819: self._guestEvent = 'Powering up' Line 1820: self._guestEventTime = 0 Line 1821: self._vmStats = None -- To view, visit http://gerrit.ovirt.org/14750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
