Federico Simoncelli has posted comments on this change.

Change subject: sp: improve masterMigrate safety
......................................................................


Patch Set 3:

(1 comment)

....................................................
File vdsm/storage/sp.py
Line 797:                 PMDK_MASTER_VER: newMasterVersion,
Line 798:             })
Line 799:             self.log.info('updating lease parameters for domain %s to 
%s',
Line 800:                           newMasterDomain.sdUUID, leaseParams)
Line 801:             newMasterDomain.changeLeaseParams(leaseParams)
Move this to masterMigrate (it should be maintained for all backends).
Line 802: 
Line 803:     def masterMigrate(self, sdUUID, msdUUID, masterVersion):
Line 804:         self.log.info("sdUUID=%s spUUID=%s msdUUID=%s", sdUUID, 
self.spUUID,
Line 805:                       msdUUID)


-- 
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to