Nir Soffer has posted comments on this change.
Change subject: sp: improve masterMigrate safety
......................................................................
Patch Set 3:
(1 comment)
After talking with Federico and checking every line that changed here, I think
the patch is ok.
We found 2 issues that should be fixed, leaving my -1 so it will not be merged
by mistake.
....................................................
File vdsm/storage/sp.py
Line 894: curmsd.unmountMaster()
Line 895: except: # logging only
Line 896: self.log.error('unable to unmount master filesystem '
Line 897: 'for domain %s', curmsd.sdUUID)
Line 898: curmsd.releaseClusterLock()
If unmount fails, we should keep the cluster lock - like we do with the new
master lock.
Line 899:
Line 900: def attachSD(self, sdUUID):
Line 901: """
Line 902: Attach a storage domain to the storage pool.
--
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
