Federico Simoncelli has posted comments on this change.

Change subject: sp: move validatePoolSD in the StoragePool class
......................................................................


Patch Set 5:

(1 comment)

....................................................
File vdsm/storage/hsm.py
Line 1343:         :type sdUUID: UUID
Line 1344:         :param options: ?
Line 1345:         """
Line 1346:         pool = self.getPool(spUUID)
Line 1347:         if not sdUUID or sdUUID != sd.BLANK_UUID:
mistake
Line 1348:             sdUUID = pool.masterDomain.sdUUID
Line 1349:         vars.task.getSharedLock(STORAGE, sdUUID)
Line 1350:         vms = pool.getVmsList(sdUUID)
Line 1351:         return dict(vmlist=vms)


-- 
To view, visit http://gerrit.ovirt.org/21787
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to