Dan Kenigsberg has submitted this change and it was merged. Change subject: sp: move validatePoolSD in the StoragePool class ......................................................................
sp: move validatePoolSD in the StoragePool class It's the StoragePool duty to validate if an operation cannot be accomplished because the storage domain is not part of the pool. For consistency with the other pool Vms API the sdUUID argument in the getVmsList method is now mandatory (it is set by the HSM public method). Change-Id: I75f0245ec5449d57431df7055be401d73975312b Signed-off-by: Federico Simoncelli <[email protected]> Reviewed-on: http://gerrit.ovirt.org/21787 Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Ayal Baron <[email protected]> --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 16 insertions(+), 24 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Verified -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
