Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: Log unhandled exception for new Thread ......................................................................
Patch Set 1: (1 comment) .................................................... File vdsm/netconf/ifcfg.py Line 737: Line 738: Line 739: def ifup(iface, async=False): Line 740: "Bring up an interface" Line 741: @utils.traceback() I am not sure about the grand benefits of this: there's nothing in this function besides calling execCmd, which does its logging anyway. All I see is duplicated log noise. Line 742: def _ifup(netIf): Line 743: rc, out, err = utils.execCmd([constants.EXT_IFUP, netIf], raw=False) Line 744: Line 745: if rc != 0: -- To view, visit http://gerrit.ovirt.org/23085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ce44b4586e85438898fcdcd2d62d80813caa5ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
