Nir Soffer has posted comments on this change.
Change subject: ifcfg: Log unhandled exception for new Thread
......................................................................
Patch Set 1:
(2 comments)
Looks good except "»" that sneaked in to the commit message.
....................................................
Commit Message
Line 7: ifcfg: Log unhandled exception for new Thread
Line 8:
Line 9: Ading a traceback log for unhandled exceptions,
Line 10: when openning a new thread, so it will not die silently.
Line 11: Since the log in ifcfg instance is inaccessible from the
decorator,
»??
Line 12: we use the default root logger.
Line 13:
Line 14: Change-Id: I2ce44b4586e85438898fcdcd2d62d80813caa5ba
....................................................
File vdsm/netconf/ifcfg.py
Line 737:
Line 738:
Line 739: def ifup(iface, async=False):
Line 740: "Bring up an interface"
Line 741: @utils.traceback()
This will help when you modify the code and break something. For example:
rc, out, err = utils.exeCmd([constants.EXT_IFUP, netIf], raw=False)
Without this log, you will get silent failure. With this patch you could easily
fix the typo and have time to send Maor a thank you letter :-)
The log noise from execCmd is another issue that we should fix separately. It
should be the responsibility of the caller to log errors, not execCmd.
Line 742: def _ifup(netIf):
Line 743: rc, out, err = utils.execCmd([constants.EXT_IFUP, netIf],
raw=False)
Line 744:
Line 745: if rc != 0:
--
To view, visit http://gerrit.ovirt.org/23085
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ce44b4586e85438898fcdcd2d62d80813caa5ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
