Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink ......................................................................
Patch Set 5: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/23248/5/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 643: def _dev_sysfs_exists(devName): Line 644: return os.path.exists(os.path.join(NET_SYSFS, devName)) Line 645: Line 646: Line 647: def _detectType(name): Speaking about patch separation, this movement does not really belongs to here. Also, I think that if you are resolved to have this function at the module level, it should be called _detectLinkType, as Routes have types, too. Line 648: """Returns the LinkType for the specified device.""" Line 649: # TODO: Add support for virtual functions Line 650: detectedType = None Line 651: try: -- To view, visit http://gerrit.ovirt.org/23248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09a120155e3c5be15c237171620e5c996c2af681 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
