Nir Soffer has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink ......................................................................
Patch Set 7: (1 comment) Only started to look at it, will continue later. http://gerrit.ovirt.org/#/c/23248/7/lib/vdsm/netlink.py File lib/vdsm/netlink.py: Line 18: # Line 19: Line 20: from contextlib import contextmanager Line 21: from ctypes import CFUNCTYPE, c_char, c_char_p, c_int, c_void_p, c_size_t Line 22: import ctypes This is ugly - either import what you need from ctypes, or import ctypes, but not both - be consistent. Line 23: import errno Line 24: Line 25: NETLINK_ROUTE = 0 Line 26: CHARBUFFSIZE = 32 -- To view, visit http://gerrit.ovirt.org/23248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09a120155e3c5be15c237171620e5c996c2af681 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
