Nir Soffer has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/23248/9/lib/vdsm/netlink.py File lib/vdsm/netlink.py: Line 61: 'rtnl_link_operstate2str', LIBNL)) Line 62: Line 63: Line 64: def _link_info(cache, link): Line 65: data = {'index': _rtnl_link_get_ifindex(link)} > OK, this can be just personal taste so feel free to ignore: We just added the same comment about this :-) Line 66: data['name'] = _rtnl_link_get_name(link) Line 67: nl_addr = _rtnl_link_get_addr(link) Line 68: if nl_addr: Line 69: address = (c_char * CHARBUFFSIZE)() -- To view, visit http://gerrit.ovirt.org/23248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09a120155e3c5be15c237171620e5c996c2af681 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
