Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Vdsm changes ......................................................................
Patch Set 19: Code-Review-1 (1 comment) please add saggi's responses to my previous questions in previous pathset. -1 for check-local change. what about the verification? I've received mail that it's somehow broken with that code.. any ideas why ? should it be rebased over http://gerrit.ovirt.org/#/c/23376 ? and the scheme changes? http://gerrit.ovirt.org/#/c/19497/19/tests/Makefile.am File tests/Makefile.am: Line 128: all-local: \ Line 129: $(nodist_vdsmtests_PYTHON) Line 130: Line 131: jsonrpc-tests.server.crt: Line 132: ./makecert.sh and if you'll run those tests manually (e.g. ./run_tests_local.sh [your_tests]) it won't work without running makecert.sh first.. so its broken currently Line 133: Line 134: # crossImportsTests.py has to be run separate due to different tests which Line 135: # load modules first, making the env dirty. Unloading python modules Line 136: # is not supported, see http://bugs.python.org/issue9072 . -- To view, visit http://gerrit.ovirt.org/19497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
