Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Vdsm changes ......................................................................
Patch Set 25: (3 comments) http://gerrit.ovirt.org/#/c/19497/25/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 115: return SSLSocket(SSL.Connection(context, sock=sock), self) Line 116: Line 117: Line 118: # This is a copy of the standard library asyncore converted to support Line 119: # compositing. Also fixes races in original implementation. just want explanation here.. what fixes?.. :/ Line 120: class AsyncChat(object): Line 121: # these are overridable defaults Line 122: Line 123: ac_in_buffer_size = 4096 http://gerrit.ovirt.org/#/c/19497/25/lib/yajsonrpc/protonReactor.py File lib/yajsonrpc/protonReactor.py: Line 25: FAILED = 0 Line 26: CONNECTED = 1 Line 27: SERVER_AUTH = 2 Line 28: CLIENT_AUTH = 3 Line 29: why 10? Line 30: MBUFF_SIZE = 10 Line 31: Line 32: Line 33: class ProtonError(RuntimeError): http://gerrit.ovirt.org/#/c/19497/25/vdsm_api/BindingJsonRpc.py File vdsm_api/BindingJsonRpc.py: Line 72: Line 73: def _createProtonListener(self, cfg): Line 74: address = cfg.get("host", "0.0.0.0") Line 75: port = cfg.get("port", 5672) Line 76: return self._reactors["amqp"].createListener((address, port)) port is hardcoded? Line 77: Line 78: def _createTcpReactor(self, truststore_path=None): Line 79: if truststore_path is None: Line 80: return AsyncoreReactor() -- To view, visit http://gerrit.ovirt.org/19497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
