Douglas Schilling Landgraf has posted comments on this change. Change subject: host-deploy: getChainFromSSL: acquire chain from session and not negotiation ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23773/1/vdsm_reg/deployUtil.py.in File vdsm_reg/deployUtil.py.in: Line 1653: def check_ignore(*args, **kw): Line 1654: return True Line 1655: Line 1656: ctx = SSL.Context() Line 1657: ctx.set_verify(SSL.verify_none, 10) I would keep: depth=10, Line 1658: with contextlib.closing(SSL.Connection(ctx)) as sock: Line 1659: # we would like to ignore any issue with certificates Line 1660: sock.set_post_connection_check_callback(check_ignore) Line 1661: sock.connect(host) Line 1659: # we would like to ignore any issue with certificates Line 1660: sock.set_post_connection_check_callback(check_ignore) Line 1661: sock.connect(host) Line 1662: # if we do not shutdown some sites hungs on close Line 1663: sock.shutdown(3) why 3? can we replace 3 with any constant like socket.SHUT_RDWR? Line 1664: return [c.as_pem() for c in sock.get_peer_cert_chain()] Line 1665: Line 1666: Line 1667: def getRhevmCert(IP, port): -- To view, visit http://gerrit.ovirt.org/23773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I397f1341984f78e8fc0a07e9256eeac362b0fcaf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
