Douglas Schilling Landgraf has posted comments on this change.

Change subject: host-deploy: getChainFromSSL: acquire chain from session and 
not negotiation
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/23773/2/vdsm_reg/deployUtil.py.in
File vdsm_reg/deployUtil.py.in:

Line 1659:         # we would like to ignore any issue with certificates
Line 1660:         sock.set_post_connection_check_callback(check_ignore)
Line 1661:         sock.connect(host)
Line 1662:         # if we do not shutdown some sites hungs on close
Line 1663:         sock.shutdown(socket.SHUT_RDWR)
> I checked this value as well and it is working.
great, thanks!
Line 1664:         return [c.as_pem() for c in sock.get_peer_cert_chain()]
Line 1665: 
Line 1666: 
Line 1667: def getRhevmCert(IP, port):


-- 
To view, visit http://gerrit.ovirt.org/23773
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I397f1341984f78e8fc0a07e9256eeac362b0fcaf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to