Nir Soffer has posted comments on this change. Change subject: vmDevices: add __slots__ to devices ......................................................................
Patch Set 4: Code-Review-1 (5 comments) This is good patch but you should fix your single item tuples. http://gerrit.ovirt.org/#/c/21036/4/vdsm/vm.py File vdsm/vm.py: Line 1309: return ctrl Line 1310: Line 1311: Line 1312: class VideoDevice(VmDevice): Line 1313: __slots__ = ('address') This is not a tuple: >>> type(('address')) <type 'str'> Line 1314: Line 1315: def getXML(self): Line 1316: """ Line 1317: Create domxml for video device Line 1749: return diskelem Line 1750: Line 1751: Line 1752: class BalloonDevice(VmDevice): Line 1753: __slots__ = ('address') Not a tuple Line 1754: Line 1755: def getXML(self): Line 1756: """ Line 1757: Create domxml for a memory balloon device. Line 1766: return m Line 1767: Line 1768: Line 1769: class WatchdogDevice(VmDevice): Line 1770: __slots__ = ('address') Not a tuple Line 1771: Line 1772: def __init__(self, *args, **kwargs): Line 1773: super(WatchdogDevice, self).__init__(*args, **kwargs) Line 1774: Line 1790: return m Line 1791: Line 1792: Line 1793: class SmartCardDevice(VmDevice): Line 1794: __slots__ = ('address') Not a tuple Line 1795: Line 1796: def getXML(self): Line 1797: """ Line 1798: Add smartcard section to domain xml Line 1809: return card Line 1810: Line 1811: Line 1812: class RedirDevice(VmDevice): Line 1813: __slots__ = ('address') Not a tuple Line 1814: Line 1815: def getXML(self): Line 1816: """ Line 1817: Create domxml for a redir device. -- To view, visit http://gerrit.ovirt.org/21036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
