Nir Soffer has posted comments on this change. Change subject: vmDevices: add __slots__ to devices ......................................................................
Patch Set 4: (1 comment) Irrelevant change sneaked into this patch - please split it. http://gerrit.ovirt.org/#/c/21036/4/vdsm/vm.py File vdsm/vm.py: Line 4992: # display indexed pairs of ordered values from 2 dicts Line 4993: # such as {key_1: (valueA_1, valueB_1), ...} Line 4994: def mergeDicts(deviceDef, dev): Line 4995: return dict((k, (deviceDef[k], getattr(dev, k, None))) Line 4996: for k in deviceDef.iterkeys()) How is this change relevant to this patch? Please split it to another patch. Line 4997: Line 4998: self.log.debug('Looking for drive with attributes %s', deviceDict) Line 4999: for d in self._devices[DISK_DEVICES]: Line 5000: if d.path == devPath: -- To view, visit http://gerrit.ovirt.org/21036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
