Federico Simoncelli has posted comments on this change.

Change subject: vm: Update LUN size when starting a vm
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/24235/2/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 266:                 # Update size for LUN volume
Line 267:                 drive["truesize"] = res['truesize']
Line 268:                 drive["apparentsize"] = res['apparentsize']
Line 269: 
Line 270:                 volPath = os.path.join("/dev/mapper", drive["GUID"])
Can you send a patch (on top of this one) to get this as well? volPath should 
be returned by appropriateDevice.
Line 271: 
Line 272:             # UUID drive format
Line 273:             elif "UUID" in drive:
Line 274:                 volPath = self._getUUIDSpecPath(drive["UUID"])


-- 
To view, visit http://gerrit.ovirt.org/24235
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4988212f7f96078e774d2a4e7b5cd1681383cb0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to