Eduardo has posted comments on this change.

Change subject: vm: Update LUN size when starting a vm
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

....................................................
File vdsm/clientIF.py
Line 267: 
Line 268:                 # Update size for LUN volume
Line 269:                 # Note: should be revisited when introducing
Line 270:                 # manual refresh of storage target functionality.
Line 271:                 volSize = self.irs.getVolumeSize(drive["GUID"])
Use the getVolumeInfo interface.

get*Size interfaces should be removed.
Line 272:                 drive["truesize"] = volSize['truesize']
Line 273:                 drive["apparentsize"] = volSize['apparentsize']
Line 274: 
Line 275:             # UUID drive format


-- 
To view, visit http://gerrit.ovirt.org/22976
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b4343c6519fed366beec415c47226d4e3c8fef
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to