Nir Soffer has posted comments on this change. Change subject: vmDevices: add __slots__ to devices ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/21036/5//COMMIT_MSG Commit Message: Line 8: Line 9: VDSM devices are created using setattr over **kwargs, making the Line 10: initialization implicit. Implementing __slots__ does define which Line 11: attributes does the device accept and also slightly improves memory footprint. Line 12: > The patch doesn't relate to the bug and doing so (setting all the attrs to So lets add a patch that change code to *not* depend on missing attribute, and instead depend on attribute being None. Line 13: Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a -- To view, visit http://gerrit.ovirt.org/21036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
