Dan Kenigsberg has submitted this change and it was merged. Change subject: vmDevices: add __slots__ to devices ......................................................................
vmDevices: add __slots__ to devices VDSM devices are created using setattr over **kwargs, making the initialization implicit. Implementing __slots__ does define which attributes does the device accept and also slightly improves memory footprint. Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a Signed-off-by: Martin Polednik <[email protected]> Reviewed-on: http://gerrit.ovirt.org/21036 Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/vm.py 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Martin Polednik: Verified -- To view, visit http://gerrit.ovirt.org/21036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
