Federico Simoncelli has uploaded a new change for review. Change subject: vm: snapshot transient disk check should be per disk ......................................................................
vm: snapshot transient disk check should be per disk Live snapshot is allowed if all the disks in the snapshot request are not transient. Change-Id: I3775e2218186e56e99740c6f91c8c98484529892 Signed-off-by: Federico Simoncelli <[email protected]> --- M vdsm/vm.py 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/24867/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index d3b4e71..edf7da3 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -3941,9 +3941,6 @@ if self.isMigrating(): return errCode['migInProgress'] - if self.hasTransientDisks(): - return errCode['transientErr'] - for drive in snapDrives: baseDrv, tgetDrv = _normSnapDriveParams(drive) @@ -3966,8 +3963,13 @@ return errCode['snapshotErr'] if vmDrive.hasVolumeLeases: + self.log.error('disk %s has volume leases', vmDrive.name) return errCode['noimpl'] + if vmDrive.transientDisk: + self.log.error('disk %s is a transient disk', vmDrive.name) + return errCode['transientErr'] + vmDevName = vmDrive.name newDrives[vmDevName] = tgetDrv.copy() -- To view, visit http://gerrit.ovirt.org/24867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3775e2218186e56e99740c6f91c8c98484529892 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
