Federico Simoncelli has posted comments on this change. Change subject: vm: snapshot transient disk check should be per disk ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24867/2/vdsm/vm.py File vdsm/vm.py: Line 3955: self.log.debug("The volume is already in use: %s", tgetDrv) Line 3956: continue # Next drive Line 3957: Line 3958: try: Line 3959: vmDrive = self._findDriveByUUIDs(baseDrv) > question - for transient won't we fail here already (before the added check We don't have an additional volume on the vdsm side. In fact when you request the transient disk hotunplug we do the exact same thing (see line 3657). Line 3960: except LookupError: Line 3961: # The volume we want to snapshot doesn't exist Line 3962: self.log.error("The base volume doesn't exist: %s", baseDrv) Line 3963: return errCode['snapshotErr'] -- To view, visit http://gerrit.ovirt.org/24867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3775e2218186e56e99740c6f91c8c98484529892 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
