Eduardo has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain ......................................................................
Patch Set 2: Code-Review-2 (1 comment) http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 207: if domain.getDomainRole() == sd.REGULAR_DOMAIN: Line 208: continue Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: SPM start should fail if one of the domains is unreacheable by the host designated of the SPM. Allowing this behaviour can lead, among others, to a situation when extend request of VMs using the missing SD are not served. If at any point in time one of the domains is unreacheable by the host, spm property should be lost. The missing domain is reported by SPM and should be used by engine to find another host to be SPM or to change the pool definition accordingly. Line 212: # log any exception, but keep going Line 213: self.log.error("Error trying to check/update domain %s role", Line 214: sdUUID, exc_info=True) Line 215: -- To view, visit http://gerrit.ovirt.org/25424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
