Sergey Gotliv has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 207: if domain.getDomainRole() == sd.REGULAR_DOMAIN: Line 208: continue Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: > This was merged in 3.0. (vdsm-4.9-112, Nov 7 16:45:00 2011) This change was introduced by I2ecf801d58b34c1c811e311e3779887a406af5f0 on December 6, 2013. Before that It wasn't a part of the spmStart flow, I think this is new. What I am missing? Line 212: # log any exception, but keep going Line 213: self.log.error("Error trying to check/update domain %s role", Line 214: sdUUID, exc_info=True) Line 215: -- To view, visit http://gerrit.ovirt.org/25424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
