Nir Soffer has posted comments on this change. Change subject: network: Introduce the network package ......................................................................
Patch Set 2: (1 comment) I like the new module names, it could be nice if the test names were also reordered under tests/network/module_test.py, instead of tests/netxxxTests.py This is too big to review - should remove unrelated changes like reorder of imports. Partial review. http://gerrit.ovirt.org/#/c/25908/2/vdsm/network/api.py File vdsm/network/api.py: Line 22: import logging Line 23: import os Line 24: import sys Line 25: import time Line 26: import traceback This change is good, but not related to this patch. Line 27: Line 28: from vdsm.config import config Line 29: from vdsm import constants Line 30: from vdsm import netinfo -- To view, visit http://gerrit.ovirt.org/25908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I532c179d4002ed1e8e5445d02297c8d5a6248647 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
