Francesco Romani has posted comments on this change. Change subject: vm: avoid to reply with half-baked statistics ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py File vdsm/API.py: Line 362: if not v: Line 363: return errCode['noVM'] Line 364: stats = v.getStats().copy() Line 365: if not stats: Line 366: return errCode['down'] > Yeah that's exactly what I was afraid of. Agreed. Then, if we want to save the concept (which I think is still sound), then we need a different error code, something like 'action failed' or 'temporarily failed'. Line 367: stats['vmId'] = self._UUID Line 368: return {'status': doneCode, 'statsList': [stats]} Line 369: Line 370: def hibernate(self, hibernationVolHandle): -- To view, visit http://gerrit.ovirt.org/25803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
