Michal Skrivanek has posted comments on this change. Change subject: vm: avoid to reply with half-baked statistics ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25803/4/vdsm/vm.py File vdsm/vm.py: Line 2815: stats['hash'] = self._devXmlHash Line 2816: if self._watchdogEvent: Line 2817: stats["watchdogEvent"] = self._watchdogEvent Line 2818: except Exception: Line 2819: self.log.error("Error fetching vm stats", exc_info=True) what I meant is that partial stats may make sense. But we can only return them iff the older engines are treating the errCode correctly Line 2820: stats = {} Line 2821: return stats Line 2822: Line 2823: def _getStatsInternal(self): -- To view, visit http://gerrit.ovirt.org/25803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
