Roy Golan has posted comments on this change. Change subject: vm: avoid to reply with half-baked statistics ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py File vdsm/API.py: Line 362: if not v: Line 363: return errCode['noVM'] Line 364: stats = v.getStats().copy() Line 365: if not stats: Line 366: return errCode['down'] > Agreed. Then, if we want to save the concept (which I think is still sound) why simply the regular errCode isn't enough? no stats, that's ok. engine will try you later. special error code is suggesting a potential specific care while this isn't the case. Line 367: stats['vmId'] = self._UUID Line 368: return {'status': doneCode, 'statsList': [stats]} Line 369: Line 370: def hibernate(self, hibernationVolHandle): -- To view, visit http://gerrit.ovirt.org/25803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
