Nir Soffer has posted comments on this change.

Change subject: performance: switch to cPickle
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/25860/9/vdsm/storage/remoteFileHandler.py
File vdsm/storage/remoteFileHandler.py:

Line 28: try:
Line 29:     import cPickle as pickle
Line 30:     pickle  # make pyflakes happy
Line 31: except ImportError:  # py3
Line 32:     import pickle
> Here and in storageServer: not sure we can use lib/vdsm code, will have a d
I think we can, this is the concept of the library, you can use it everywhere.
Line 33: import signal
Line 34: import sys
Line 35: import select
Line 36: from contextlib import contextmanager


-- 
To view, visit http://gerrit.ovirt.org/25860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to