Dan Kenigsberg has submitted this change and it was merged. Change subject: performance: switch to cPickle ......................................................................
performance: switch to cPickle profiling of the creation code path shows that the impact of pickle is not negligible. cPickle is a safe drop-in replacement, so this patch switch to it for the sake of performance. considering a 'monday morning' scenario (mass parallel start of many VMs) we see ~5% improvement in startup time before: mean: 27.984s stdev=1.074s best: 10.507s stdev=1.604s worst: 42.711s stdev=1.996s total: 895.479s stdev=34.375s after: mean: 26.423s stdev=1.413s best: 9.785s stdev=1.669s worst: 40.833s stdev=2.452s total: 845.523s stdev=45.218s pickle is used to save the VM params for checkpointing, so the benefits should affect, possibly with lower extent, to all VM operation flows. Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/25860 Reviewed-by: Antoni Segura Puimedon <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/API.py M vdsm/clientIF.py M vdsm/storage/remoteFileHandler.py M vdsm/storage/storageServer.py M vdsm/virt/vm.py 5 files changed, 6 insertions(+), 5 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
