Yaniv Bronhaim has posted comments on this change. Change subject: Refactor VM._guestSockCleanup into utils.rmFileAndLink ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26479/3/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 115: with open(filePath, 'a'): Line 116: os.utime(filePath, None) Line 117: Line 118: Line 119: def rmFileAndLink(fileToRemove): i'd call it rmSymlinksAndFile and remove all the links if exist, imo it more useful .. but maybe im wrong Line 120: """ Line 121: Try to remove a file and if it is a link remove the linked file as well. Line 122: If the file or link does not exists it is assumed that it was already Line 123: removed. -- To view, visit http://gerrit.ovirt.org/26479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I749d5e15c91e0046ac700d2eec7220aa7cbd8ac2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
