Dan Kenigsberg has posted comments on this change. Change subject: Refactor VM._guestSockCleanup into utils.rmFileAndLink ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26479/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-04-07 09:39:44 +0200 Line 4: Commit: Vinzenz Feenstra <[email protected]> Line 5: CommitDate: 2014-04-08 10:24:25 +0200 Line 6: Line 7: Refactor VM._guestSockCleanup into utils.rmFileAndLink The need for VM._guestSockCleanup is very specific. I see no general need for the suggested utils.rmFileAndLink, as its semantics is a bit peculiar. If you have a general circumstances such as s1 -> s2 -> h1 -> inode s3 ---------^ ^ h2 ---^ ans s1 is passed to the funciton, only s1 and h1 would be removed. Line 8: Line 9: Change-Id: I749d5e15c91e0046ac700d2eec7220aa7cbd8ac2 -- To view, visit http://gerrit.ovirt.org/26479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I749d5e15c91e0046ac700d2eec7220aa7cbd8ac2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
