Dan Kenigsberg has posted comments on this change. Change subject: custom_net_props: blacklist 'custom' for ifcfg configurator ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26655/1/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1938: them the call succeeds.""" Line 1939: with dummyIf(1) as nics: Line 1940: nic, = nics Line 1941: network = {NETWORK_NAME: {'nic': nic, 'vlan': VLAN_ID, Line 1942: 'custom': {'linux': 'rules', 'vdsm': 'as well'}}} could you merge this into testBeforeNetworkSetupHook, and verify that "custom" is visible inside the hook script? Line 1943: status, msg = self.vdsm_net.setupNetworks(network, {}, Line 1944: NOCHK) -- To view, visit http://gerrit.ovirt.org/26655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4eba375ed64333b960c1cdb5e77bbd1c998c2d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
